Skip to content

Fix broken infinite scrolling by downgrading @vueuse/core to a version supporting vue2 #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 3 commits into from
Apr 3, 2025
Merged

Fix broken infinite scrolling by downgrading @vueuse/core to a version supporting vue2 #1960

artonge merged 3 commits into from
Apr 3, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 3, 2025 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 32 milestone Apr 3, 2025
@nickvergessen nickvergessen self-assigned this Apr 3, 2025
@codecov
Copy link

codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.89%. Comparing base (a5f17c0) to head (a1ff1c8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/views/ActivityAppFeed.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1960      +/-   ##
==========================================
+ Coverage   30.85%   30.89%   +0.03%     
==========================================
  Files          43       43              
  Lines        1617     1615       -2     
  Branches      110      110              
==========================================
  Hits          499      499              
+ Misses       1092     1090       -2     
  Partials       26       26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Apr 3, 2025 •
edited
Loading

Activity    Run #2464

Run Properties:  status check failed Failed #2464  •  git commit 184d396192: Fix broken infinite scrolling by downgrading @vueuse/core to a version supportin...
Project Activity
Branch Review bugfix/noid/fix-scrolling
Run status status check failed Failed #2464
Run duration 03m 01s
Commit git commit 184d396192: Fix broken infinite scrolling by downgrading @vueuse/core to a version supportin...
Committer Joas Schilling
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/sidebar.cy.ts • 1 failed test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has rename activity Screenshots

@artonge artonge merged commit 124cc6e into master Apr 3, 2025
53 of 59 checks passed
@artonge artonge deleted the bugfix/noid/fix-scrolling branch April 3, 2025 14:46
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@hamza221 hamza221 hamza221 approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels

3. to review bug feature: stream

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @artonge @hamza221 @Antreesy @skjnldsv