Skip to content

Make container view looks proportional on viewport #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solracsf wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make container view looks proportional on viewport #1700

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bcce6f
Make container view looks proportional on viewport
solracsf Jun 6, 2024
134e7d1
Fix lint
solracsf Jun 6, 2024
b57ad43
fix: move scroll bar to the page edge
ShGKme Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/views/ActivityAppFeed.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,10 @@ watch(props, () => {
&__container {
display: flex;
flex-direction: column;

height: 100%;
width: min(100%, 924px);
max-width: 924px;
margin: 0 auto;
padding-inline: 12px;
// Align with app navigation toggle
margin: var(--app-navigation-padding, 8px) 0 0 calc(2 * var(--app-navigation-padding, 8px) + 44px);
Copy link
Contributor

@ShGKme ShGKme Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin: var(--app-navigation-padding, 8px) 0 0 calc(2 * var(--app-navigation-padding, 8px) + 44px);
margin: var(--app-navigation-padding, 8px) 0 0 calc(2 * var(--app-navigation-padding, 8px) + var(--default-clickable-area));

Copy link
Contributor

@ShGKme ShGKme Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we should also add a variable or component for that to not calculate it all the time in each app...

I'll do it later today.

Copy link
Member Author

@solracsf solracsf Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem; same code a few lines down.

padding-inline: 0 44px;
Copy link
Contributor

@ShGKme ShGKme Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this padding is defined by the a button size

Suggested change
padding-inline: 0 44px;
padding-inline: 0 var(--default-clickable-area);

overflow-y: scroll;
}

Expand Down