Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 24, 2025

☑️ Resolves

  • make 'id' non-required prop, generate default instead (is it breaking?)
  • align styles with other input elements (alignment and hvoer effects)
  • remove duplicated docs examples (already on next)

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component labels Jan 24, 2025
@Antreesy Antreesy added this to the 8.23.0 milestone Jan 24, 2025
@Antreesy Antreesy requested review from ShGKme and susnux January 24, 2025 09:21
@Antreesy Antreesy self-assigned this Jan 24, 2025
- label positioning - NcSelect
- hover effects - NcInputField

Signed-off-by: Maksim Sukharev <[email protected]>
- first one covers them all

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/date-picker-styles branch from d475038 to b0e6483 Compare January 27, 2025 12:27
@Antreesy Antreesy requested a review from DorraJaouad January 27, 2025 12:32
@susnux susnux merged commit 8ad2ac6 into master Jan 29, 2025
23 checks passed
@susnux susnux deleted the fix/noid/date-picker-styles branch January 29, 2025 13:19
@susnux
Copy link
Contributor

susnux commented Jan 29, 2025

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: datepicker Related to the date/time picker component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants