fix(NcListItem): Make paddings smaller again on Nextcloud 30 #5879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Antreesy
reviewed
Jul 29, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
top+bottom spacing seems a bit bigger, but I assume, that is because of avatart heigth = 44px and text reserved height = 48px
For stable29 it would be the similar issue 44 < 48:
| Prod | This PR |
|---|---|
 |
 |
susnux
force-pushed
the
fix/nc-list-item-height
branch
from
6a713be to
a6498bc
Compare
Contributor
Author
You are right, compared it with the previous version, and for legacy we just need 8px (2 * grid) padding. |
Antreesy
approved these changes
Jul 29, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Looks fine. Icon is provided by parent component, so size/left margin should be adjusted on apps side anyway (to make a border width around icon nice)
ShGKme
approved these changes
Jul 29, 2024
Add a `legacy` class so that we can keep stylings for Nextcloud 29 and older but still can style the component properly on Nextcloud 30 (smaller border radius = we can use smaller paddings) Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/nc-list-item-height
branch
from
f6275f2 to
bf4e529
Compare
Merged
2 tasks
Contributor
|
/backport to next |
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Add a
legacyclass so that we can keep stylings for Nextcloud 29 and older but still can style the component properly on Nextcloud 30 (smaller border radius = we can use smaller paddings)🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade