fix: Migrate SCSS $clickable-area to CSS --default-clickable-area
#5694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
requested review from
juliusknorr,
raimund-schluessler,
skjnldsv and
susnux
7 tasks
susnux
reviewed
Jun 12, 2024
susnux
reviewed
Jun 12, 2024
susnux
reviewed
Jun 12, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
marcoambrosini
force-pushed
the
feat/change-default-clickable-area
branch
from
250e77d to
193f916
Compare
susnux
reviewed
Jun 17, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Similar with the other cases
marcoambrosini
force-pushed
the
feat/change-default-clickable-area
branch
from
193f916 to
cfcf998
Compare
marcoambrosini
force-pushed
the
feat/change-default-clickable-area
branch
from
cfcf998 to
4557fb5
Compare
susnux
force-pushed
the
feat/change-default-clickable-area
branch
3 times, most recently
from
b325efc to
929cf08
Compare
susnux
added
bug
susnux
force-pushed
the
feat/change-default-clickable-area
branch
2 times, most recently
from
c9b32f6 to
fe89ea7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ShGKme
reviewed
Jun 20, 2024
marcoambrosini
force-pushed
the
feat/change-default-clickable-area
branch
from
fe89ea7 to
ee87644
Compare
marcoambrosini
force-pushed
the
feat/change-default-clickable-area
branch
from
ee87644 to
0272cd4
Compare
Contributor
Author
Contributor
Author
ShGKme
reviewed
Jun 29, 2024
susnux
approved these changes
Jul 1, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Unbreaking for 28 and 29, for 30 it fixes some weird places so 👍
| /* Keep padding to define the width to | ||
| assure correct position of a possible text */ | ||
| padding: #{math.div($clickable-area, 2)} 0 #{math.div($clickable-area, 2)} $clickable-area; | ||
| padding: calc(var(--default-clickable-area)/ 2) 0 calc(var(--default-clickable-area)/ 2) var(--default-clickable-area); |
Contributor
There was a problem hiding this comment.
Maybe we should cache calc(var(--default-clickable-area)/ 2)? (note for the future)
| /* Keep padding to define the width to | ||
| assure correct position of a possible text */ | ||
| padding: #{math.div($clickable-area, 2)} 0 #{math.div($clickable-area, 2)} $clickable-area; | ||
| padding: calc(var(--default-clickable-area) / 2) 0 calc(var(--default-clickable-area) / 2) var(--default-clickable-area); |
Contributor
There was a problem hiding this comment.
because here we use it again
| // bottom-right corner | ||
| position: absolute; | ||
| right: $icon-margin + 1; | ||
| right: calc($icon-margin + 1); |
Contributor
There was a problem hiding this comment.
we should get rid of this options in the future (...-right, ...-left, right, left) to properly support RTL layout and just use ...-inline-start ...-inline-end.
Just a note for the future, not related to this PR 😅
susnux
changed the title
$clickable-area to CSS --default-clickable-area
ShGKme
approved these changes
Jul 1, 2024
susnux
force-pushed
the
feat/change-default-clickable-area
branch
from
a4084be to
8df3711
Compare
Contributor
|
Todo:
|
Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Grigorii K. Shartsev <[email protected]> Signed-off-by: Marco <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/change-default-clickable-area
branch
from
8df3711 to
5f2ff37
Compare
Contributor
|
/backport to next |
2 tasks
Contributor
|
Milestone is 8.14 for this one? |
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of nextcloud/server#45657