Skip to content

fix: regression in list item's extra slot #5250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hamza221 wants to merge 1 commit into from
Closed

fix: regression in list item's extra slot #5250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/components/NcListItem/NcListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,21 +394,20 @@
</div>
</div>
</div>
<!-- Actions -->
Copy link
Contributor

@susnux susnux Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must not be done! An interactive element (the a) must not contain any other interactive element (the NcActions).
We changed this just a couple of weeks ago.

<div v-show="forceDisplayActions || displayActionsOnHoverFocus"
class="list-item-content__actions"
@focusout="handleBlur">
<NcActions ref="actions"
:primary="isActive || active"
:aria-label="computedActionsAriaLabel"
@update:open="handleActionsUpdateOpen">
<!-- @slot Provide the actions for the right side quick menu -->
<slot name="actions" />
</NcActions>
</div>
</a>

<!-- Actions -->
<div v-show="forceDisplayActions || displayActionsOnHoverFocus"
class="list-item-content__actions"
@focusout="handleBlur">
<NcActions ref="actions"
:primary="isActive || active"
:aria-label="computedActionsAriaLabel"
@update:open="handleActionsUpdateOpen">
<!-- @slot Provide the actions for the right side quick menu -->
<slot name="actions" />
</NcActions>
</div>

<!-- @slot Extra elements below the item -->
<div v-if="$slots.extra" class="list-item__extra">
<slot name="extra" />
Expand Down Expand Up @@ -732,7 +731,7 @@ export default {
// NcListItem
.list-item {
box-sizing: border-box;
display: flex;
display: block;
position: relative;
flex: 0 0 auto;
justify-content: flex-start;
Expand Down