Skip to content

Increase contrast on input field for NcRichContenteditable #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuliaKirschenheuter merged 1 commit into from
Dec 19, 2023
Merged

Increase contrast on input field for NcRichContenteditable #4975

JuliaKirschenheuter merged 1 commit into from
Dec 19, 2023

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Dec 19, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2023-12-19 11-10-44 Screenshot from 2023-12-19 11-08-39

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Dec 19, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 19, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Dec 19, 2023
Closed
3 tasks
ShGKme
ShGKme approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sure that I saw this PR already...

@JuliaKirschenheuter JuliaKirschenheuter merged commit ae8fd2e into master Dec 19, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/41879-increase_contrast_for_input_field_on_rich_content_editable branch December 19, 2023 11:50
@ShGKme ShGKme added bug Something isn't working accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: rich-contenteditable Related to the rich-contenteditable components labels Dec 22, 2023
@ShGKme ShGKme added this to the 8.4.0 milestone Dec 22, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 22, 2023

Remember to add enhancement label for new features and bug for fixing bugs, including accessibility or adjustments 😀

@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components

Projects

None yet

Milestone

8.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JuliaKirschenheuter @ShGKme @susnux