Skip to content

Prevent NcBreadcrumb from automatically inheriting attributes #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuliaKirschenheuter merged 1 commit into from
Dec 6, 2023
Merged

Prevent NcBreadcrumb from automatically inheriting attributes #4918

JuliaKirschenheuter merged 1 commit into from
Dec 6, 2023

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Dec 5, 2023

☑️ Resolves

Part of nextcloud/server#41895

Prevent aria-label from being a part of <li>

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2023-12-05 14-42-36 Screenshot from 2023-12-05 14-43-17

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Dec 5, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 5, 2023
ShGKme
ShGKme approved these changes Dec 5, 2023
View reviewed changes
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41895-fix-breadcrumb-navigation branch from 2c85cf4 to 7e7cd68 Compare December 6, 2023 08:44
@JuliaKirschenheuter JuliaKirschenheuter merged commit 8008811 into master Dec 6, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/41895-fix-breadcrumb-navigation branch December 6, 2023 09:27
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Dec 6, 2023
Closed
@ShGKme ShGKme added bug Something isn't working accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Dec 22, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 22, 2023

Remember to add enhancement label for new features and bug for fixing bugs, including accessibility or adjustments 😀

@ShGKme ShGKme added the feature: breadcrumbs Related to the breadcrumbs components label Dec 22, 2023
@ShGKme ShGKme added this to the 8.4.0 milestone Dec 22, 2023
@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@szaimen szaimen Awaiting requested review from szaimen

+1 more reviewer

@Pytal Pytal Pytal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: breadcrumbs Related to the breadcrumbs components

Projects

None yet

Milestone

8.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JuliaKirschenheuter @ShGKme @Pytal