fix(NcRichContenteditable): Fix pasting XML and HTML content#3915
Merged
nickvergessen merged 1 commit intomasterfrom Mar 23, 2023
Merged
fix(NcRichContenteditable): Fix pasting XML and HTML content#3915nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
nickvergessen
added
bug
nickvergessen
added
3. to review
skjnldsv
requested changes
Mar 23, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/3264/fix-pasting-xml-content
branch
from
ce4c9e9 to
35c79ee
Compare
Antreesy
approved these changes
Mar 23, 2023
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
document.createTextNode also allows to escape HTML characters, so there is no need to do it twice
skjnldsv
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3264
Fix nextcloud/spreed#9104