Skip to content

Improve using of native datetime picker #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuliaKirschenheuter merged 1 commit into from
Sep 12, 2022
Merged

Improve using of native datetime picker #3183

JuliaKirschenheuter merged 1 commit into from
Sep 12, 2022

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Sep 6, 2022 •
edited
Loading

Resolves #3182

Provide inheritAttrs with false value for NcDateTimePickerNativ.vue

Extend types for min and max props

@JuliaKirschenheuter
Provide inheritAttrs with false value for NcDateTimePickerNativ…
1e03abc 
…e.vue

Extend types for ```min``` and ```max``` props

Signed-off-by: julia.kirschenheuter <[email protected]>
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Sep 6, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Sep 6, 2022
@ChristophWurst
Copy link
Contributor

ChristophWurst commented Sep 6, 2022

Just a part of big improvement issue.

link?

@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Sep 6, 2022
Merged
1 task
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Sep 12, 2022

link?

it resolves first 2 points

  • Provide inheritAttrs: false
  • Extend types for min and max props

ChristophWurst
ChristophWurst approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@JuliaKirschenheuter JuliaKirschenheuter merged commit 9a76052 into master Sep 12, 2022
@JuliaKirschenheuter JuliaKirschenheuter deleted the enh/3182-futher_improvements_for_native_datetime_picker branch September 12, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Further improvements for native datetime picker

4 participants

@JuliaKirschenheuter @ChristophWurst @CarlSchwan