-
Notifications
You must be signed in to change notification settings - Fork 96
Open
Labels
1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care ofaccessibilityMaking sure we design for the widest range of people possible, including those who have disabilitiesMaking sure we design for the widest range of people possible, including those who have disabilitiesbugSomething isn't workingSomething isn't workingfeature: userbubbleRelated to the userbubble componentRelated to the userbubble component
Description
There NcUserBubble is used as a clickable div to implement manual router navigation. It is a UX and a11y issue (how to open it in a new tab or via keyboard?).
- Instead, it's better to add
RouterLinksupport to this component. Then it will be actually an interactive link element - feat(NcUserBubble): add RouterLink support #5708 -
divcan be replaced withbuttonora role="button"feat(NcUserBubble): add RouterLink support #5708 (comment)
Originally posted by @ShGKme in #5708 (review)
Metadata
Metadata
Assignees
Labels
1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care ofaccessibilityMaking sure we design for the widest range of people possible, including those who have disabilitiesMaking sure we design for the widest range of people possible, including those who have disabilitiesbugSomething isn't workingSomething isn't workingfeature: userbubbleRelated to the userbubble componentRelated to the userbubble component