NcDialog: Padding not applied correctly

[Chartman123]

nextcloud-vue/src/components/NcDialog/NcDialog.vue

Lines 393 to 394 in c8da0f4

	padding-block: 4px 8px; // 4px to align with close button, 8px block-end to allow the actions a margin of 4px for the focus visible outline
	padding-inline: 12px 8px; // Same as with padding-block, we need the actions to have a margin of 4px for the button outline

The padding specified in the above rules is not applied correctly. To solve this problem !important should be added to those two lines.

[susnux]

!important should be avoided where possible to allow users of the library to override the styles if needed (e.g. the filepicker in this case)

[ShGKme]

Isn't it fixed by

• fix(NcDialog): Increase specificity for modal-content selector #4897

[Chartman123]

Is this already released? If not, yes this should probably fix it...

[ShGKme]

Is this already released? If not, yes this should probably fix it...

Not yet.

[susnux]

Is fixed with the latest release at least it looks correct, reopen if I am wrong.