Skip to content

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 18, 2024

image

@Koc here is my take on this.
I think adding some text to the right isn't the right approach.
Now we make sure we don't have any ongoing upload that are NOT assembling
If all is left is assembling tasks, we show the status.

  • Assembling status uploader fix
  • Assembling status vue component feat
  • Cypress tests

Closes #1458

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Dec 18, 2024
@skjnldsv skjnldsv requested review from artonge, nfebe and susnux December 18, 2024 18:16
@skjnldsv skjnldsv self-assigned this Dec 18, 2024
@codecov
Copy link

codecov bot commented Dec 18, 2024

Bundle Report

Changes will increase total bundle size by 1.33kB (0.17%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@nextcloud/upload-esm 396.52kB 666 bytes (0.17%) ⬆️
@nextcloud/upload-cjs 399.88kB 666 bytes (0.17%) ⬆️

@Koc
Copy link
Contributor

Koc commented Dec 19, 2024

@skjnldsv Awesome! But it still not works for me. Reproducer:

  1. set max chunk size to 40 Mb
  2. upload 2 files in parallel: 35 Mb (smaller than chunk to have regular upload) and 150 Mb (few times bigger than chunk to have chunked upload)

Expected: Progressbar shows upload progress and assembling status until all files are not uploaded and assembled
Actual: Progressbar hidden once 1st file uploaded. So, assembling status not shown.

nextcloud-upload-2024-12-19_10.09.23.mp4

@skjnldsv
Copy link
Contributor Author

Will add tests and fix that use case, nice catch! :)

@Koc
Copy link
Contributor

Koc commented Jan 2, 2025

@skjnldsv as an option - we can merge current PR as is and fix my edge case in separate PR

@susnux
Copy link
Contributor

susnux commented Feb 25, 2025

@skjnldsv rebased + added a commit with the missing tests and fixed the issue (the job queue was empty after upload as we did not add the assembling to the queue so it was reset = whole status reset)

@skjnldsv skjnldsv merged commit 2f8ce18 into main Feb 25, 2025
21 checks passed
@skjnldsv skjnldsv deleted the feat/assembly branch February 25, 2025 14:43
@skjnldsv skjnldsv mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants