Fix dialog not appearing when another modal is open#387
Merged
ChristophWurst merged 1 commit intomasterfrom Sep 12, 2022
Merged
Fix dialog not appearing when another modal is open#387ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
Pytal
added
bug
This was referenced Sep 10, 2022
Merged
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/modal-focus-trap-loop
branch
from
f72c044 to
0ae3fc0
Compare
ChristophWurst
approved these changes
Sep 12, 2022
Contributor
|
This required v7.0.0-beta.5 Currently master is broken |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dialog not appearing from the infinite focus trap loop due to the dialog and modal being mounted as siblings instead of being nested as described in tailwindlabs/headlessui#825 (comment)
The solution is to mount the dialog within the existing modal
Prepending to the previous modal is not enough as NcModal automatically remounts itself to
document.bodyby default https://github.com/nextcloud/nextcloud-vue/blob/v7.0.0-beta.2/src/components/NcModal/NcModal.vue#L555-L561So to prevent automatic mounting in NcModal
nullis passed to thecontainerpropThis will show errors in the console that can be dismissed as it has no effect other than preventing automatic remounting but is addressed in nextcloud-libraries/nextcloud-vue#3219