fix: When sorting by filename the extension should only be considered if the basename is equal #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
type: bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
==========================================
+ Coverage 80.19% 80.23% +0.03%
==========================================
Files 20 20
Lines 515 516 +1
Branches 136 136
==========================================
+ Hits 413 414 +1
Misses 100 100
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 226 bytes ⬆️
|
kesselb
approved these changes
Jun 13, 2024
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
LGTM 👍
Test case for files without extension would be nice.
skjnldsv
approved these changes
Jun 14, 2024
… if the basename is equal Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-sorting-extension
branch
from
232d60c to
eabc2d2
Compare
Contributor
Author
It is already there (the very first one), but added an additional test case just to be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not take the file extension into account while sorting, only if the basename is equal.