Skip to content

Export FilePickerType enum - #556

Merged
nickvergessen merged 1 commit into
masterfrom
enh/export-file-picker-type-enum
Apr 8, 2022
Merged

Export FilePickerType enum#556
nickvergessen merged 1 commit into
masterfrom
enh/export-file-picker-type-enum

Conversation

@Pytal

@Pytal Pytal commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

Allow users of this package to use the more easily grokked

getFilePickerBuilder('Choose a file or folder to transfer')
	.setType(FilePickerType.Choose)
	.build()

instead of

getFilePickerBuilder('Choose a file or folder to transfer')
	.setType(1)
	.build()

@Pytal Pytal self-assigned this Apr 7, 2022
ChristophWurst
ChristophWurst approved these changes Apr 7, 2022
View reviewed changes

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@Pytal
Export FilePickerType enum
5435985 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytal force-pushed the enh/export-file-picker-type-enum branch from 6476d59 to 5435985 Compare April 8, 2022 02:35
@Pytal

Pytal commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

CI hanged so trying again

@nickvergessen

nickvergessen commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

Was not CI hanging, but after #546 the required tests where not adjusted. Fixed it now.

@nickvergessen
nickvergessen merged commit d782cdc into master Apr 8, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the enh/export-file-picker-type-enum branch April 8, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes
@nickvergessen nickvergessen Awaiting requested review from nickvergessen
@juliusknorr juliusknorr Awaiting requested review from juliusknorr
@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal @nickvergessen @ChristophWurst