chore: use consistent note about contributing and authors#31
Merged
Conversation
Contributor
susnux
commented
Nov 5, 2025
susnux
commented
- Add note about contributing (DCO)
- Add AUTHORS.md just like with our other projects
- Adjust usage of AUTHORS
susnux
force-pushed
the
chore/consistent-contribution
branch
from
5c5fea0 to
50cc72f
Compare
ChristophWurst
approved these changes
Nov 6, 2025
skjnldsv
approved these changes
Nov 6, 2025
ShGKme
reviewed
Nov 6, 2025
Comment on lines
+7
to
+14
| - Andy Scherzinger <info@andy-scherzinger.de> | ||
| - Christoph Wurst <christoph@winzerhof-wurst.at> | ||
| - Ferdinand Thiessen <opensource@fthiessen.de> | ||
| - Grigorii K. Shartsev <me@shgk.me> | ||
| - John Molakvoæ <skjnldsv@protonmail.com> | ||
| - Julius Härtl <jus@bitgrid.net> | ||
| - Pytal <24800714+Pytal@users.noreply.github.com> | ||
| - Roeland Jago Douma <rullzer@users.noreply.github.com> |
Contributor
There was a problem hiding this comment.
Is it the list of contributors, or the list of contributors being listed in the old @copyright comments before migrating to SPDX header?
Contributor
Author
There was a problem hiding this comment.
tried to recreate the copyright headers
Contributor
There was a problem hiding this comment.
Did you run
For gaining authors from git as well?
Contributor
There was a problem hiding this comment.
I just saw myself on this list, but I never added myself to the copyright header.
What strategy did the script use?
- Add note about contributing (DCO) - Add AUTHORS.md just like with our other projects - Adjust usage of AUTHORS Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/consistent-contribution
branch
from
2af0a4f to
5f91707
Compare
AndyScherzinger
approved these changes
Nov 6, 2025
Contributor
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Looks good to me, the git comment to help with author detection could be a follow up or might have been used already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.