Skip to content

fix(firebase): add ability to pass in firebase config #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chanceaclark wants to merge 1 commit into from
Closed

fix(firebase): add ability to pass in firebase config #5055

chanceaclark wants to merge 1 commit into from

Conversation

@chanceaclark
Copy link
Contributor

@chanceaclark chanceaclark commented Jul 31, 2022 •
edited
Loading

☕️ Reasoning

Adds the ability to pass in Firebase config into the adapter to initialize the app, rather than initializing by default. This is useful if you've initialized the app on the client and want to reuse the config on the server. Alongside that, adds some documentation on how to use it.

Note: Ran prettier --write packages/adapter-firebase which cleaned up some files.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #4927

📌 Resources

@vercel
Copy link

vercel bot commented Jul 31, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-auth ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 6:54PM (UTC)

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters firebase @auth/firebase-adapter labels Jul 31, 2022
@vercel vercel bot temporarily deployed to Preview July 31, 2022 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview July 31, 2022 17:47 Inactive
@chanceaclark chanceaclark mentioned this pull request Jul 31, 2022
Closed
@chanceaclark chanceaclark marked this pull request as ready for review July 31, 2022 17:50
@chanceaclark
Copy link
Contributor Author

chanceaclark commented Jul 31, 2022

cc. @balazsorban44

@itsmylife
Copy link

itsmylife commented Aug 25, 2022

@chanceaclark @balazsorban44 @ndom91 @lluia Sorry for pinging you all but will we have approval soon?

@vercel vercel bot temporarily deployed to Preview September 2, 2022 18:54 Inactive
@balazsorban44 balazsorban44 force-pushed the main branch 6 times, most recently from 19c6807 to 3be7bb7 Compare January 7, 2023 08:50
@balazsorban44 balazsorban44 mentioned this pull request Jan 19, 2023
Merged
3 tasks
balazsorban44 pushed a commit that referenced this pull request Feb 5, 2023
@wyattades
feat(adapters): move to firebase-admin in Firebase Adapter (#6225)
6445eb6 
Co-authored-by: Balázs Orbán <[email protected]>
fixes #5049
closes #6230
closes #5449
closes #5055
fixes #4927

BREAKING CHANGE:
The adapter now expects `firebase-admin` instead of the `firebase` package and also supports either passing a config object or a firestore instance.
balazsorban44 pushed a commit that referenced this pull request Feb 5, 2023
@wyattades @balazsorban44
feat(adapters): move to firebase-admin in Firebase Adapter (#6225)
4258857 
Co-authored-by: Balázs Orbán <[email protected]>
fixes #5049
closes #6230
closes #5449
closes #5055
fixes #4927

BREAKING CHANGE:
The adapter now expects `firebase-admin` instead of the `firebase` package and also supports either passing a config object or a firestore instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0ubbe 0ubbe Awaiting requested review from 0ubbe

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

Assignees

No one assigned

Labels

adapters Changes related to the core code concerning database adapters firebase @auth/firebase-adapter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firebase Adapter Fails with App Name Already exist error

2 participants

@chanceaclark @itsmylife