Skip to content

fix(providers): properly warn when using Twitter OAuth 2 #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2022
Merged

fix(providers): properly warn when using Twitter OAuth 2 #3784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e42f37
fix(providers): properly warn when using Twitter OAuth 2
balazsorban44 Feb 2, 2022
265df1e
refactor(providers): move Twitter OAuth2 warning to `assert`
balazsorban44 Feb 2, 2022
4ddf37f
fix: use proper warning code
balazsorban44 Feb 2, 2022
7cf5bf6
refactor: only set boolean
balazsorban44 Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/core/lib/assert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,13 @@ export function assertConfig(
if (!req.host) return "NEXTAUTH_URL"

let hasCredentials, hasEmail
let hasTwitterProvider

options.providers.forEach(({ type }) => {
if (type === "credentials") hasCredentials = true
else if (type === "email") hasEmail = true
})
for (const provider of options.providers) {
if (provider.type === "credentials") hasCredentials = true
else if (provider.type === "email") hasEmail = true
else if (provider.id === "twitter") hasTwitterProvider = true
}

if (hasCredentials) {
const dbStrategy = options.session?.strategy === "database"
Expand All @@ -75,4 +77,8 @@ export function assertConfig(
if (hasEmail && !options.adapter) {
return new MissingAdapter("E-mail login requires an adapter.")
}

if (hasTwitterProvider) {
return "TWITTER_OAUTH_2_BETA"
}
}
2 changes: 1 addition & 1 deletion src/lib/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function hasErrorProperty(
return !!(x as any)?.error
}

export type WarningCode = "NEXTAUTH_URL" | "NO_SECRET"
export type WarningCode = "NEXTAUTH_URL" | "NO_SECRET" | "TWITTER_OAUTH_2_BETA"

/**
* Override any of the methods, and the rest will use the default logger.
Expand Down
7 changes: 1 addition & 6 deletions src/providers/twitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,10 @@ export interface TwitterProfile {
}
}

let warned = false
export default function Twitter<
P extends Record<string, any> = TwitterLegacyProfile | TwitterProfile
>(options: OAuthUserConfig<P>): OAuthConfig<P> {
if (!warned && options.version === "2.0") {
warned = true
console.warn(
"Opted-in to Twitter OAuth 2.0. See the docs https://next-auth.js.org/providers/twitter#oauth-2"
)
if (options.version === "2.0") {
return {
id: "twitter",
name: "Twitter",
Expand Down