Skip to content

Conversation

@balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jan 4, 2022

The config assertions did only check the top-level secret option, but currently, we allow jwt.secret as well. That option could just go away in the future.

Fixes #3560

UPDATE:

On hold. See #3560 (comment)

Reasoning 💡

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

@github-actions github-actions bot added the core Refers to `@auth/core` label Jan 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3561 (ca52357) into main (c71cb84) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3561   +/-   ##
=======================================
  Coverage   13.27%   13.27%           
=======================================
  Files          90       90           
  Lines        1424     1424           
  Branches      378      378           
=======================================
  Hits          189      189           
  Misses       1224     1224           
  Partials       11       11           
Impacted Files Coverage Δ
src/core/lib/assert.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71cb84...ca52357. Read the comment docs.

@balazsorban44 balazsorban44 marked this pull request as draft January 4, 2022 01:49
@balazsorban44
Copy link
Member Author

Closed by #3783

@balazsorban44 balazsorban44 deleted the fix/assert-jwt-secret branch December 3, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Refers to `@auth/core`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NEXTAUTH_URL has been set but it still shows [next-auth][error][CLIENT_FETCH_ERROR]

3 participants