Update multiverse suites to Ruby 2.6+ #3337
Open
+107
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
commented
Nov 19, 2025
| https://github.com/newrelic/newrelic-ruby-agent/ | ||
| EOS | ||
| s.email = '[email protected]' | ||
| # TODO: MAJOR VERSION - remove newrelic, deprecated since version xxx. |
Contributor
Author
There was a problem hiding this comment.
Removing this was a bonus, it should've been removed in deprecating newrelic in favor of newrelic_rpm #3323
Contributor
There was a problem hiding this comment.
Oh interesting, I missed this in my major version Todo PR as well even though its marked with it. I think it's because I have my search function only check .rb files usually, so .gemspec didn't show up. I'll have to keep that in mind
test/new_relic/github/workflows/scripts/generate_release_notes_test.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Reopelle <[email protected]>
…/newrelic-ruby-agent into multiverse_ruby_36_plus
Contributor
SimpleCov Report
|
kaylareopelle
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the testing of and conditions for Ruby < 2.6 from the test suites.
Its also removes a straggler
newrelicexecutable line that should have been removed in deprecating thenewrelicexecutable in favor ofnewrelic_rpm