Skip to content

Force Disable CAT #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 20, 2025
Merged

Force Disable CAT #3333

merged 9 commits into from
Nov 20, 2025

Conversation

@tannalynn
Copy link
Contributor

@tannalynn tannalynn commented Nov 18, 2025 •
edited
Loading

This removes the ability for CAT to be used and deletes the API methods that were specific to CAT.

  • removed config
  • removed 4 public api methods related to CAT (and the file some of them were in)
  • Deleted tests testing for CAT behavior

@tannalynn tannalynn changed the base branch from dev to v10_0_0 November 18, 2025 17:34
@tannalynn tannalynn changed the title Remove CAT Force Disable CAT Nov 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

SimpleCov Report

Coverage Threshold
Line 93.32% 93%

@kaylareopelle
Copy link
Contributor

kaylareopelle commented Nov 18, 2025

Relates to #3272

@tannalynn tannalynn marked this pull request as ready for review November 19, 2025 17:26
@tannalynn tannalynn requested a review from a team as a code owner November 19, 2025 17:26
kaylareopelle
kaylareopelle reviewed Nov 19, 2025
View reviewed changes
lib/new_relic/agent/distributed_tracing/cross_app_tracing.rb
end
end

def cross_application_tracer_enabled?
Copy link
Contributor

@kaylareopelle kaylareopelle Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do the other methods in this module give us if a customer can't enable CAT?

Copy link
Contributor Author

@tannalynn tannalynn Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won't be keeping these long term, but I'm not ripping out everything in this PR, just force disabling CAT and removing publicly documented api methods.

@tannalynn tannalynn merged commit 9bbb3fc into v10_0_0 Nov 20, 2025
158 of 161 checks passed
@tannalynn tannalynn deleted the remove_cat branch November 20, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannahramadan hannahramadan hannahramadan approved these changes

@kaylareopelle kaylareopelle kaylareopelle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tannalynn @kaylareopelle @hannahramadan