DRAFTDONOTMERGE feat(agent): handle special segment starts with fibers#1215
Draft
zsistla wants to merge 2 commits into
Draft
DRAFTDONOTMERGE feat(agent): handle special segment starts with fibers#1215zsistla wants to merge 2 commits into
zsistla wants to merge 2 commits into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/fibers #1215 +/- ##
===============================================
- Coverage 80.20% 80.19% -0.01%
===============================================
Files 190 190
Lines 27830 27840 +10
===============================================
+ Hits 22320 22327 +7
- Misses 5510 5513 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This causes different behavior than just passing the parent to nr_segment_start as a parameter to segment start. Please note the updated documentation for nr_segment_start. The updated documentation does NOT reflect new behavior. It reflects CURRENT behavior that was not previously documented as such.
New segments should be started in the context of their parent for proper parentage. auto_segment helps with this.
zsistla
force-pushed
the
fiber/handle_segment_start
branch
from
82615f9 to
97b699c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.