ENH: add lock parameter to Dataset.deposit
#246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
enh/deposit_locking_strategy
branch
2 times, most recently
from
fd82f42 to
f6af0d1
Compare
neutrinoceros
changed the title
lock_strategy parameter to Dataset.depositlock parameter to Dataset.deposit
neutrinoceros
force-pushed
the
enh/deposit_locking_strategy
branch
7 times, most recently
from
b23c441 to
ee940ab
Compare
Merged
neutrinoceros
force-pushed
the
enh/deposit_locking_strategy
branch
from
3f26b28 to
b22f8d0
Compare
neutrinoceros
force-pushed
the
enh/deposit_locking_strategy
branch
from
40c217f to
c66b5a5
Compare
neutrinoceros
force-pushed
the
enh/deposit_locking_strategy
branch
from
c66b5a5 to
04e096e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #245: releasing the GIL and not having any sort of lock to replace it degrades performance in the general case, so it seems preferable to have some locking mechanism by default (while still allowing it to be disabled, as an opt-out)
TODO:
per-instanceandglobal, and choose a sane default if both should be conserved