Skip to content

Exporting shapes to Region of interest objects#544

Closed
harsh-bhanushali-05 wants to merge 13 commits intoneuroinformatics-unit:mainfrom
harsh-bhanushali-05:Export_ROI
Closed

Exporting shapes to Region of interest objects#544
harsh-bhanushali-05 wants to merge 13 commits intoneuroinformatics-unit:mainfrom
harsh-bhanushali-05:Export_ROI

Conversation

@harsh-bhanushali-05
Copy link
Copy Markdown
Contributor

@harsh-bhanushali-05 harsh-bhanushali-05 commented Apr 5, 2025

Description

This is a draft pr right now and doesn't contain testcases nor has been tested with precommit. This PR is just for feedback from mentors.

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
issue #378
What does this PR do?
Creates a ROI layer using the polygon and line in the roi folder.

Added another widget which lets users export shapes as a ROI Layer with custom names.
image

Roi Layers then in turn can be exported to JSON or .h5 file (Header of the file is similar to the one used by DeepLabCut ie ROI can be loaded through the load tracked data widget)
image

Made a separate load roi feature is the export is in JSON format.
Which are overlapped with the original shapes layer.

Basically I have I have tried to implement all the functionalities mentioned by @niksirbi in PR #489
This is still a draft PR as I am not sure if the implementation is exactly what was required and the .h5 file give a flipped results sometimes (Working on the later)

Any feedback would be really helpful!

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2025

@niksirbi
Copy link
Copy Markdown
Member

In an effort to tidy up the repository ahead of the holidays, we’re reducing the number of open PRs. As part of that process, I’m closing this PR as it has gone stale.

This is partly on us as maintainers — when the PR was opened, we didn’t have the capacity to provide timely feedback.

@harsh-bhanushali-05 thanks for taking the time to work on this. I’m now addressing #378 myself and taking an entirely different approach, but I will revisit the code here, and if I end up using any of it I’ll be sure to give due credit.

@niksirbi niksirbi closed this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants