[BUG] - Fix sim_bursty_oscillation for passing in burst_def array directly#349
Merged
Conversation
Closed
TomDonoghue
changed the title
ryanhammonds
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #334, implementing new fix discussed there
In the original PR @ryanhammonds pointed out there is a bug with
sim_bursty_oscillationno longer taking in a pre-defined burst array properly. There are some quirks to keeping the ordering (see #334), so this PR adds a new fixUpdates:
burst_defto not fail with an array input