[ENH] - Add functionality for managing sim params and simulating multiple signals together#329
Merged
Conversation
Member
ryanhammonds
left a comment
There was a problem hiding this comment.
Looks good! I reviewed all the module code. I probably should've started with the tutorials to get a better sense of usage, so sorry if some of the comments lack foresight.
The tests are the only thing I didn't review. I can come back to those if you want. But since they pass / have coverage, I'm happy with them.
Member
Author
|
I think everything pertaining specifically to the updates here is addressed, so I'm going to merge this in now to move forward with integrating this new approach into a project. We should test this whole approach out a bit more before tagging the next version release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Aperiodic Method project, I was simulating large groups of signals while both systematically iterating across parameter values and/or sampling from parameter distributions. In order to do so, I had to develop some utilities for managing simulation parameters and simulating groups of time series together.
This PR suggests adding that functionality directly into NDSP. It is all quite general, and I think fits well within the sim module. The code added here is basically the code that is demo'd in the aperiodic methods project here (which might be a good starting point to get a feel for how this approach looks / works): https://aperiodicmethods.github.io/notebooks/12-TimeSimsParameters.html
I've also sketched out some tutorials, which give a broad overview of the general approach / how this code works.