[ENH] - Plot updates & extensions#319
Conversation
ryanhammonds
left a comment
There was a problem hiding this comment.
Looks good! I added a few optional comments. Something to think about for the future though is a separate plotting package the signals/psds, as the plotting functionality here grows.
|
Thanks for checking @ryanhammonds! I made some updates based on your comments, if you want to check the update for the multi plot in particular (since what the API for that should be is not so obvious). And yeh, I agree - as things grow, we should definitely consider "what belongs where" and if/when we might consider splitting things out from ndsp. I've been meaning to do a proper sweep of code for a bit, so maybe let's check in on this sometime soon, as we check in on what goes into 2.3, what goes after, and any things we need to figure out on the roadmap otherwise. |
Some additions & tweaks to plotting including:
plot_styleThe upshot of the style update is that something like this now works:
Note: the tests on newer versions of python were failing on a doctest, where an answer that used to come out at 2.0 is now 2.000000000000026 (or something) - so I added rounding to this check.