Skip to content

scipy.signal.convolve >>> np.convolve#310

Merged
ryanhammonds merged 5 commits into
mainfrom
convolve
Jan 20, 2023
Merged

scipy.signal.convolve >>> np.convolve#310
ryanhammonds merged 5 commits into
mainfrom
convolve

Conversation

@ryanhammonds
Copy link
Copy Markdown
Member

Brad's update to decrease filtering runtime.

@TomDonoghue
Copy link
Copy Markdown
Member

Test are fixed in #309 btw

@ryanhammonds
Copy link
Copy Markdown
Member Author

Whoops, I missed that PR. Thanks! I'll review / merge it.

@TomDonoghue
Copy link
Copy Markdown
Member

@ryanhammonds - it does similar to what you were doing, but updates some other github actions things that stops some future deprecation warnings that otherwise pop up in the actions log. At some point I did a sweep - there's an equivalent PR open on bycycle

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #310 (af68d64) into main (1498cc5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files         100      100           
  Lines        2812     2812           
=======================================
  Hits         2765     2765           
  Misses         47       47           
Impacted Files Coverage Δ
neurodsp/filt/fir.py 95.91% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ryanhammonds ryanhammonds merged commit 65df273 into main Jan 20, 2023
@TomDonoghue TomDonoghue deleted the convolve branch February 11, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants