scipy.signal.convolve >>> np.convolve#310
Merged
Merged
Conversation
Member
|
Test are fixed in #309 btw |
Member
Author
|
Whoops, I missed that PR. Thanks! I'll review / merge it. |
Member
|
@ryanhammonds - it does similar to what you were doing, but updates some other github actions things that stops some future deprecation warnings that otherwise pop up in the actions log. At some point I did a sweep - there's an equivalent PR open on bycycle |
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 100 100
Lines 2812 2812
=======================================
Hits 2765 2765
Misses 47 47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brad's update to decrease filtering runtime.