Add support for mac m1 #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We should support m1 as more and more users are switching to it. Modifications: - Add profile for boringssl-static to cross compile for m1 - Adjust finish release script to also include m1 Result: Mac M1 is supported
|
Does compiling require an actual M1 chipset? I mean, will you be manually compiling binary on your M1 machine? |
|
@hyperxpro no its cross-compiling on intel. |
chrisvest
reviewed
Sep 8, 2021
| <osxCrossCompile>true</osxCrossCompile> | ||
| <macOsxDeploymentTarget/> | ||
| <cmakeOsxDeploymentTarget/> | ||
| <cflags>-target arm64-apple-macos11 -Werror -fno-omit-frame-pointer -fvisibility=hidden -Wunused -Wno-unused-value -O3</cflags> |
There was a problem hiding this comment.
Not in this PR, but at some point I think it would be good to have -Werror be controlled by a property, so people can turn it off if they have a different compiler or compiler version.
jakub-id
added a commit
to folio-org/okapi
that referenced
this pull request
Nov 24, 2021
Which includes updated netty and netty-tcnative with M1 support, see netty/netty-tcnative#662
This was referenced Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should support m1 as more and more users are switching to it.
Modifications:
Result:
Mac M1 is supported