isPlainObject/isArray validation, falsy values for presence validation, node 0.10.x support when running tests #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrmatos
changed the title
bjrmatos
changed the title
| field: paramName, | ||
| message: customMessage || message(paramName, "required"), | ||
| result: !!get(params, paramName) | ||
| result: get(params, paramName) != null |
Owner
|
@bjrmatos Your PR looks really good. |
bjrmatos
force-pushed
the
isPlainObject-isArray-validation
branch
from
16ac42d to
efb89dc
Compare
Collaborator
Author
|
PR updated with your observations ❤️ |
Owner
|
This is looking fantastic, @bjrmatos. |
Collaborator
Author
|
@nettofarah done! 😄 |
Owner
|
Great! Thank you! |
nettofarah
added a commit
that referenced
this pull request
Mar 10, 2016
isPlainObject/isArray validation, falsy values for presence validation, node 0.10.x support when running tests
Owner
|
I'll publish a new release tomorrow |
Collaborator
Author
|
@nettofarah thnk you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while preparing a PR for #9 i've noticed that running npm test is broken in node v0.10 due the use of template literals.