Skip to content

feat: use atomic pointer for global feature flag client #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2022
Merged

feat: use atomic pointer for global feature flag client #332

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
614a43e
feat: use rwmutex when accessing global feature flag client
cbosss Apr 27, 2022
4482ef1
changed to atomic pointer
cbosss Apr 27, 2022
d75ea8a
Merge branch 'main' into cole/feature-flag-rwmutex
cbosss May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions featureflag/global.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"github.com/sirupsen/logrus"
)

var globalLock sync.Mutex
var globalLock sync.RWMutex
var globalClient Client = MockClient{}

func SetGlobalClient(client Client) {
Expand All @@ -19,8 +19,8 @@ func SetGlobalClient(client Client) {
}

func GetGlobalClient() Client {
globalLock.Lock()
defer globalLock.Unlock()
globalLock.RLock()
defer globalLock.RUnlock()
return globalClient
}

Expand Down