Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

chore: updated SvelteKit framework info #818

Merged
kodiakhq merged 1 commit into from
Oct 4, 2022
Merged

chore: updated SvelteKit framework info #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/frameworks/svelte-kit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"configFiles": []
},
"dev": {
"command": "svelte-kit dev",
"port": 3000,
"command": "vite dev",
"port": 5173,
"pollingStrategies": [{ "name": "TCP" }, { "name": "HTTP" }]
},
"build": {
"command": "svelte-kit build",
"directory": "build"
"command": "vite build",
"directory": ".svelte-kit"
Copy link
Contributor

@ericapisani ericapisani Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to worry about sites with older versions of SvelteKit breaking with this change? I know we had a similar conversation with respect to vite but I think there might be a lot more users that this change would affect.

Copy link
Contributor Author

@nickytonline nickytonline Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had thought about this, kind of like the PR #792, but in this case, these are the settings for the first official release for SvelteKit.

This also brings up the conversation again about potentially versioning framework information.

Copy link

@brittneypostma brittneypostma Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I mentioned to Nick in slack. There is a workaround by adding the targetPort to the netlify,toml file that can be added by anyone on an older version, but this will fix it so new updated sites don't have to do the workaround to get the CLI command to work.

Copy link
Contributor

@ericapisani ericapisani Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks both!

},
"logo": {
"default": "/logos/svelte-kit/default.svg",
Expand Down
2 changes: 1 addition & 1 deletion src/frameworks/vite.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"category": "build_tool",
"detect": {
"npmDependencies": ["vite"],
"excludedNpmDependencies": ["@shopify/hydrogen", "@builder.io/qwik", "solid-start", "solid-js"],
"excludedNpmDependencies": ["@shopify/hydrogen", "@builder.io/qwik", "solid-start", "solid-js", "@sveltejs/kit"],
Copy link
Contributor Author

@nickytonline nickytonline Oct 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding SvelteKit as an excluded dependency so it doesn't get picked up by the vite framework info config.

"configFiles": []
},
"dev": {
Expand Down