This repository was archived by the owner on Jan 11, 2023. It is now read-only.
chore: changed qwik default port to 5173#801
Merged
nickytonline merged 3 commits intomainfrom Sep 23, 2022
Merged
Conversation
Contributor
Author
|
I'm going to put this back to draft for the moment, because I'm not sure if this framework is meant to only be used with our Edge starter, https://github.com/BuilderIO/qwik/tree/main/starters/servers/netlify |
ericapisani
previously approved these changes
Aug 2, 2022
89423ac
89423ac to
52b7088
Compare
ericapisani
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
npm init qwik@latestsets a new qwik app's local development port to 5173 to line up with changes to vite's recent port change. Given the project is fairly new, this should have minimal impact, if any to folks using Qwik on Netlify. This was originally part if #792, but since we're still discussing the change to the vite default port, I opted to put this in its own PR.And if for some reason they are using the old port currently, a message will notify them that they can change the target port in the netlify.toml
Relates to #791
For us to review and ship your PR efficiently, please perform the following steps:
ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)