feat: add packagePath property for config #5223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request adds or modifies JavaScript ( |
lukasholzer
commented
Aug 7, 2023
| build: { | ||
| environment: {}, | ||
| publish: '.', | ||
| publish: packagePath || '.', |
Contributor
Author
There was a problem hiding this comment.
This is for Option A inside the Slack discussion: https://netlify.slack.com/archives/C05556LEX28/p1691423437855069
lukasholzer
commented
Aug 7, 2023
packages/config/src/files.ts
Outdated
| const path = originalPath.replace(LEADING_SLASH_REGEXP, '') | ||
| // TODO: Based on survey outcome: https://netlify.slack.com/archives/C05556LEX28/p1691423437855069 | ||
| // If we like option B then: | ||
| // const pathA = resolve(baseRel, packagePath || '', path) |
Contributor
Author
There was a problem hiding this comment.
This would be Option B in the discussion: https://netlify.slack.com/archives/C05556LEX28/p1691423437855069
eduardoboucas
previously approved these changes
Aug 7, 2023
eduardoboucas
approved these changes
Aug 8, 2023
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Is part of fixing: https://github.com/netlify/pod-dev-foundations/issues/571
To be able to detect
_headersor_redirectsfor a package when working from the repository root we need an additional field calledpackage_paththis will be set via the site picker on the React UI and persisted on the API.By providing this to netlify config we can still separate the execution root from the location where we store and retrieve the configuration.
The implementation depends on this conversation here: https://netlify.slack.com/archives/C05556LEX28/p1691423437855069
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)