Skip to content

chore: Implement pytest in Diode#469

Merged
manrodrigues merged 26 commits into
developfrom
pytest-diode
Jan 28, 2026
Merged

chore: Implement pytest in Diode#469
manrodrigues merged 26 commits into
developfrom
pytest-diode

Conversation

@manrodrigues
Copy link
Copy Markdown
Contributor

@manrodrigues manrodrigues commented Jan 22, 2026

@mfiedorowicz as we discussed earlier today:

  • removing behave tests
  • Adding structure to pytest tests
  • Adding minimal ingestion with netbox validation considering plugin without assurance

please, if you (or anyone else) have suggestions, let me know. This is the best time to just change everything that is needed :)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 22, 2026

CLA assistant check
All committers have signed the CLA.

@manrodrigues manrodrigues changed the title Pytest diode OBS-1923 - Implement pytest in Diode Jan 22, 2026
Comment thread tests/requirements.txt Outdated
@manrodrigues manrodrigues changed the title OBS-1923 - Implement pytest in Diode chore: OBS-1923 - Implement pytest in Diode Jan 23, 2026
@manrodrigues manrodrigues changed the title chore: OBS-1923 - Implement pytest in Diode chore: Implement pytest in Diode Jan 23, 2026
Comment thread tests/requirements.txt
Co-authored-by: Michal Fiedorowicz <[email protected]>
@netboxlabs netboxlabs deleted a comment from chatgpt-codex-connector Bot Jan 27, 2026
@manrodrigues
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59baa7279e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/plugin/test_plugin_web_endpoints.py Outdated
Comment thread tests/plugin/test_plugin_web_endpoints.py
@manrodrigues
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b88400f24d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/plugin/test_plugin_web_endpoints.py Outdated
@manrodrigues
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 011d1007c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/README.md Outdated
@manrodrigues
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e31d1a74a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/plugin/test_plugin_web_endpoints.py Outdated
@manrodrigues
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/README.md Outdated
Comment thread tests/README.md
Copy link
Copy Markdown
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@manrodrigues manrodrigues merged commit 1f56d16 into develop Jan 28, 2026
6 checks passed
@manrodrigues manrodrigues deleted the pytest-diode branch January 28, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants