670 - Add extra branching support to pynetbox #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovinger
previously approved these changes
May 19, 2025
| ... sites = nb.dcim.sites.all() | ||
| ... # All operations within this block will use the branch's schema | ||
| """ | ||
| if not isinstance(branch, Record) or not "schema_id" in dict(branch): |
Member
There was a problem hiding this comment.
I was going to ask if this isinstance() check could be more explicit, but I don't think it can be without creating a model for netbox_branching objects in pynetbox, right?
jnovinger
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #670
creates an activate_branch function that is a context manager to use different branches. Adds documentation to optionally use tenacity library for waiting, incremental backoff, etc.. to define a wait_for_branch_status function to aid script authors.