fix: logger print invalid context when no stack trace provided#16307
Merged
kamilmysliwiec merged 2 commits intonestjs:masterfrom Feb 5, 2026
Merged
fix: logger print invalid context when no stack trace provided#16307kamilmysliwiec merged 2 commits intonestjs:masterfrom
kamilmysliwiec merged 2 commits intonestjs:masterfrom
Conversation
Pull Request Test Coverage Report for Build f2299e45-9676-4504-a184-e3991acbf705Details
💛 - Coveralls |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using the
ConsoleLogger.errorwith two parameters, the logger will assumed that the second parameter is an Error or override of the context.If the second parameter not a
stringor anError, it will use the second parameter as the context instead of using the default context of the Logger.Ex:
Will log
{ level: 'error', pid: 1, timestamp: 1770231457646, message: 'Unexpected error', context: { requestId: '123456' } }What is the new behavior?
When using the
ConsoleLogger.errorwith two parameters, when the second parameter is not an Error, the logger will fallback to the default logger logic the detect the context from the provided arguments.Will log
{ level: 'error', pid: 1, timestamp: 1770231457646, message: 'Unexpected error', context: 'MyCustomLogger' } { level: 'error', pid: 1, timestamp: 1770231457646, message: { requestId: '123456' }, context: 'MyCustomLogger' }Does this PR introduce a breaking change?
Other information