fix(core): make get() throw for implicitly request-scoped trees#15865
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Nov 14, 2025
Merged
Conversation
Treat non-static dependency trees as scoped in get(); instruct consumers to use resolve().\n\nAdds focused tests under NestApplicationContext spec to cover implicit request scope via enhancers.\n\nCloses nestjs#15836.
Closed
4 tasks
Pull Request Test Coverage Report for Build 513890a5-e0b5-48f6-83b7-3f896faedcccDetails
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here’s a concise PR body you can paste:
Treat non-static dependency trees as scoped in get(); instruct consumers to use resolve().
Adds focused tests under NestApplicationContext spec to cover implicit request scope via enhancers.
Closes #15836.
PR Checklist
PR Type
What is the current behavior?
Calling module.get on a class whose dependency tree is implicitly non-static (e.g., due to a request‑scoped pipe/guard) returns a prototype-only instance with undefined injections, rather than throwing. Users don’t get guidance to use resolve().
Issue Number: #15836
What is the new behavior?
module.get now throws InvalidClassScopeException for non-static dependency trees (implicit request scope), instructing users to use resolve(). module.resolve continues to instantiate per-context correctly. Added tests to cover both get (throws) and resolve (works).
Does this PR introduce a breaking change?
Other information