feat(common): add method options to @sse decorator#15863
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Nov 14, 2025
TomerSteinberg:TomerSteinberg-feat/sse-method-options
Merged
feat(common): add method options to @sse decorator#15863kamilmysliwiec merged 1 commit intonestjs:masterfrom TomerSteinberg:TomerSteinberg-feat/sse-method-options
kamilmysliwiec merged 1 commit intonestjs:masterfrom
TomerSteinberg:TomerSteinberg-feat/sse-method-options
Conversation
Pull Request Test Coverage Report for Build 1874048a-c11d-46df-aeda-b62a4468bf2aDetails
💛 - Coveralls |
Yedidyar
approved these changes
Nov 2, 2025
Member
|
AFAIR this is against the spec, isn't it? |
Contributor
Author
|
Thanks for the reply! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the
@Ssedecorator is hardcoded to use theGETmethod, which limits certain use cases where anEventSourcepolyfill on the client side uses a differentHTTPmethod.Issue Number: N/A
What is the new behavior?
The new behavior allows specifying which
HTTPmethod the endpoint supports, while still defaulting toGETif none is providedDoes this PR introduce a breaking change?
Other information
This is my first time contributing to a repository, so please excuse any beginner mistakes I may have made.