Skip to content

Fix/rmq microservice fanout bind#15747

Merged
kamilmysliwiec merged 5 commits intonestjs:masterfrom
slon2015:fix/rmq-microservice-fanout-bind
Oct 21, 2025
Merged

Fix/rmq microservice fanout bind#15747
kamilmysliwiec merged 5 commits intonestjs:masterfrom
slon2015:fix/rmq-microservice-fanout-bind

Conversation

@slon2015
Copy link
Contributor

@slon2015 slon2015 commented Oct 7, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #15746

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Enforce the client and server to bind the queue to exchange
Tests for new fanout exchange functional

FIXES: nestjs#15746
@coveralls
Copy link

coveralls commented Oct 7, 2025

Pull Request Test Coverage Report for Build 0204bf64-9742-4092-b778-345b881741c6

Details

  • 12 of 14 (85.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 88.836%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-rmq.ts 6 7 85.71%
packages/microservices/server/server-rmq.ts 6 7 85.71%
Totals Coverage Status
Change from base Build bdf8f055-4cf2-40ae-a7a2-1f06f79197e6: 0.1%
Covered Lines: 7289
Relevant Lines: 8205

💛 - Coveralls

The client queue assertion and bind prevent for cases when exchange will be used for send
@kamilmysliwiec
Copy link
Member

Would you like to add an integration test for this change?

@slon2015
Copy link
Contributor Author

Integration test added

@slon2015
Copy link
Contributor Author

@kamilmysliwiec do you have any other feedback?

@kamilmysliwiec kamilmysliwiec merged commit bf80d39 into nestjs:master Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants