Fix/rmq microservice fanout bind#15747
Merged
kamilmysliwiec merged 5 commits intonestjs:masterfrom Oct 21, 2025
Merged
Conversation
Enforce the client and server to bind the queue to exchange
Tests for new fanout exchange functional FIXES: nestjs#15746
Pull Request Test Coverage Report for Build 0204bf64-9742-4092-b778-345b881741c6Details
💛 - Coveralls |
4 tasks
ad0bed3 to
bf59ad2
Compare
The client queue assertion and bind prevent for cases when exchange will be used for send
Member
|
Would you like to add an integration test for this change? |
Generated queue name use in the server channel setup process
Contributor
Author
|
Integration test added |
Hardanish-Singh
approved these changes
Oct 14, 2025
Contributor
Author
|
@kamilmysliwiec do you have any other feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #15746
What is the new behavior?
Does this PR introduce a breaking change?
Other information