Use unique_ptr< SecondaryEvent > to avoid memory leaks#3562
Merged
heplesser merged 14 commits intonest:masterfrom Sep 11, 2025
Merged
Use unique_ptr< SecondaryEvent > to avoid memory leaks#3562heplesser merged 14 commits intonest:masterfrom
heplesser merged 14 commits intonest:masterfrom
Conversation
…eaks. Co-authored-by: med-ayssar <med.ayssar@gmail.com>
Contributor
|
Comparing the Valgrind memory-leak logs of nest master to those of PR #3562, PR #3561, and |
Contributor
|
Measuring runtime and memory usage against both the unpatched NEST version and a temporary fix using nest-simulator/nestkernel/connection_manager.cpp Lines 1688 to 1697 in b737f23 |
akorgor
approved these changes
Sep 11, 2025
Contributor
akorgor
left a comment
There was a problem hiding this comment.
Thank you for this valuable fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #3501 using the
std::unique_ptrapproach suggested by @med-ayssar in that issue.@akorgor Could you test this with Valgrind? Could you also check against master that using
unique_ptrdoes not slow down simulations?@med-ayssar Could you review as well?