Optimize computation in GrowthCurveGaussian#3304
Merged
heplesser merged 5 commits intonest:masterfrom Sep 5, 2024
Merged
Conversation
Replace FP divides with FP multiplies. Pre-compute constants.
heplesser
added
S: Normal
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
heshpdx
added a commit
to heshpdx/nest-simulator
that referenced
this pull request
Sep 3, 2024
Replace FP divides with FP multiplies and pre-compute loop invariants. Similar to nest#3304
otcathatsya
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves one of the hottest functions be reducing unnecessary computation. Removes one sqrt and three divs outside the loop, and two divs inside the loop. I measured about 10% speedup on my machine, depending on the workload.
1/(2*sqrt(ln(2)))instead of calculating it each time the function is called.Can you please check my math? For some reason the spike recorder on structural_plasticity_benchmark.sli seems to be giving different output. My other workloads still produce the same results. Thanks!