Add note to aeif models about refractory period and peculiarities#3296
Merged
jessica-mitchell merged 3 commits intonest:masterfrom Oct 28, 2024
Merged
Add note to aeif models about refractory period and peculiarities#3296jessica-mitchell merged 3 commits intonest:masterfrom
aeif models about refractory period and peculiarities#3296jessica-mitchell merged 3 commits intonest:masterfrom
Conversation
jessica-mitchell
added
S: Normal
Contributor
|
The formulation "The default refractory period [...] is zero, [...]. This means if the refractory period is zero, [...]" is perhaps a little bit of a non sequitur. Suggest to remove "This means" from the second sentence. |
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
heplesser
requested changes
Oct 27, 2024
github-actions
bot
removed
the
stale
heplesser
approved these changes
Oct 28, 2024
clinssen
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3088
This PR adds a note to all
aeifmodels, including the reference if needed based on the comment in #3088.The technical reason was left out, since the focus should be on usage imo.
See output from Read the Docs here: https://nest-simulator--3296.org.readthedocs.build/en/3296/models/aeif_psc_exp.html