Fix Izhikevich model equation in the documentation#3220
Fix Izhikevich model equation in the documentation#3220jessica-mitchell merged 11 commits intonest:masterfrom
Conversation
|
Fixes #3219 |
|
Could you make the variable naming of |
@clinssen Are you talking about these lines of code? nest-simulator/models/izhikevich.h Line 209 in bf55cc4 |
|
The alignment should probably be done globally via CSS or other options instead; entering spaces like this is a bit too ad-hoc and can break things in the future. Re the naming, see nest-simulator/models/izhikevich.h Line 88 in bf55cc4 |
|
Hi! I made changes, let me know if it's okay now) |
jessica-mitchell
left a comment
There was a problem hiding this comment.
hi @PrabhuUdurg after reviewing with @pnbabu, we realize that the u should be U_m and any case of v should be V_m. I made some suggestions but could you please check the page if there are any cases of u or v that still need to be updated. Thanks!
|
@jessica-mitchell I will change it and submit new pull request, thanks! |
There was a problem hiding this comment.
@PrabhuUdurg Can you also update lines 59 - 68, where u and v are mentioned and change them to the correct ones?
Also, can you merge master - we had an update that fixes a test and our CI pipeline won't pass unless your branch is up-to-date with master.
|
@jessica-mitchell Should v on line 60 be changed to V_m too? |
yep |
jessica-mitchell
left a comment
There was a problem hiding this comment.
Thanks @PrabhuUdurg looks good!
Thank you for assistance! My first merged request) |
Solved issue about not rendered equation on the following page: https://nest-simulator.readthedocs.io/en/latest/models/izhikevich.html
Also I centered it, to make it look better with another equation.