Skip to content

Add clang-format pre-commit hook#2936

Merged
terhorstd merged 2 commits intonest:masterfrom
nicolossus:pre_commit
Sep 19, 2023
Merged

Add clang-format pre-commit hook#2936
terhorstd merged 2 commits intonest:masterfrom
nicolossus:pre_commit

Conversation

@nicolossus
Copy link
Member

This PR introduces a pre-commit hook for clang-format. By default, the hook uses the .clang-format file from the root.

The PR also adds the end-of-file-fixer and trailing-whitespace hooks. They are out-of-the-box hooks from pre-commit, which already is a dependency. These particular hooks might save a lot of back-and-forth with CI.

@terhorstd terhorstd added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 19, 2023
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@terhorstd
Copy link
Contributor

Since this does not affect the simulator, but only improves developer tooling, I'll merge with single review.

@terhorstd terhorstd merged commit 4d8d3bf into nest:master Sep 19, 2023
@nicolossus nicolossus deleted the pre_commit branch September 19, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

Comments