Sli2py iaf_psc_alpha_multisynapse#2929
Merged
heplesser merged 6 commits intonest:masterfrom Oct 20, 2023
Merged
Conversation
added 3 commits
September 11, 2023 16:21
terhorstd
added
S: Normal
terhorstd
changed the title
iaf_psc_alpha_multisynapse
nicolossus
suggested changes
Oct 17, 2023
Member
nicolossus
left a comment
nicolossus
left a comment
There was a problem hiding this comment.
@janskaar Thanks, overall this looks good! I have some minor suggestions for which I have created a PR towards your branch, see janskaar#1.
…napse Suggestions from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.