Filter connections also by target when dumping layer connections#2920
Merged
jougs merged 13 commits intonest:masterfrom Sep 7, 2023
Merged
Filter connections also by target when dumping layer connections#2920jougs merged 13 commits intonest:masterfrom
jougs merged 13 commits intonest:masterfrom
Conversation
nicolossus
added
T: Bug
heplesser
reviewed
Sep 4, 2023
Contributor
heplesser
left a comment
heplesser
left a comment
There was a problem hiding this comment.
Thanks @nicolossus. I just have one question and suggestion concerning the test.
Conflicts: pynest/nest/lib/hl_api_spatial.py
heplesser
approved these changes
Sep 7, 2023
Contributor
heplesser
left a comment
heplesser
left a comment
There was a problem hiding this comment.
@nicolossus Thank you! I will approve this now, but am slightly irritated that we needed the stringify_path() to support SLI shortly before SLI will be a matter of the past. Could you create a follow up issue to remove it again? An maybe create another follow-up issue to remind us to see if we want to convert all path handling to pathlib.
jougs
approved these changes
Sep 7, 2023
Contributor
jougs
left a comment
jougs
left a comment
There was a problem hiding this comment.
This looks good to me. I guess we can handle the removal of the stringify_path function in the merge to new-pynest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2629.
The main purpose of this PR is to fix the bug reported in #2629. The reason for the bug was that the internal kernel call to
get_connectionsdid not filter by the provided targetNodeCollection.The PR also introduces some minor changes regarding more informative variable names and declaring the appropriate data type. More majorly, the
findfunctions ofnode_collection.hare renamed toget_lidto better reflect that the functions return an index and not an iterator (thefindfunction for a container typically returns an iterator).The final addition of this PR is that path-like objects are now allowed to be passed as filename to
DumpLayerConnections.