Add support to set mpi address via device status#2858
Merged
jougs merged 3 commits intonest:masterfrom Jul 12, 2023
Merged
Conversation
Co-authored-by: Muhammad Fahad Azeemi <fahadazeemi@gmail.com> Co-authored-by: Kim Sontheimer <k.sontheimer@fz-juelich.de>
jougs
added
T: Enhancement
jougs
requested changes
Jul 12, 2023
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
jougs
approved these changes
Jul 12, 2023
Contributor
jougs
left a comment
jougs
left a comment
There was a problem hiding this comment.
Many thanks for this nice contribution.
Contributor
|
@sontheimer: could you maybe quickly indicate your approval as a potential consumer of this new feature? Thanks! |
sontheimer
approved these changes
Jul 12, 2023
sontheimer
left a comment
sontheimer
left a comment
There was a problem hiding this comment.
the changes were tested locally with a NEST-TVB cosimulation. Works as intended, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the refactored approach of the MPI address discussed in #2585.
The mpi address can be set via the device status.
E.g.: