Skip to content

Improve error checking in MPI IO backends#2857

Merged
jougs merged 4 commits intonest:masterfrom
VRGroupRWTH:mpi_error_checking
Jul 12, 2023
Merged

Improve error checking in MPI IO backends#2857
jougs merged 4 commits intonest:masterfrom
VRGroupRWTH:mpi_error_checking

Conversation

@marcelkrueger
Copy link
Contributor

@marcelkrueger marcelkrueger commented Jul 12, 2023

This PR improves error handling in two cases:

  1. If the file that is supposed to be read via the path given in the device label does not exist, it will throw an appropriate exception.
  2. Check the MPI connect call's return code to ensure the connection was successful.
    Previously, it failed silently if, e.g., a wrong MPI address was supplied.

@jougs jougs added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jul 12, 2023
@jougs jougs changed the title Improve error checking in MPI backend Improve error checking in MPI IO backends Jul 12, 2023
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Many thanks for your contribution!

@jougs jougs requested a review from mlober July 12, 2023 12:33
Copy link

@jens-br jens-br left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jougs jougs removed the request for review from mlober July 12, 2023 12:48
@jougs jougs merged commit e68bbb7 into nest:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants

Comments